Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Subject: Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Date: Sat, 02 Nov 2013 09:23:29 -0300

To: Ben Gamari, notmuch@notmuchmail.org

Cc:

Ben Gamari <bgamari.foss@gmail.com> writes:

> We never checked to ensure that the rmtree() of the old database
> succeeded.
>

Is there some reason these patches (and the existing compact code in the
lib) is using fprintf and not the status callback function? Most places
we don't (yet) have logging callbacks, but here we do.

d

Previous message (by thread): Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Thread:

Ben Gamari—[PATCH 1/4] test: Add compact test [inbox, notmuch::obsolete, notmuch::patch, unread]
- Ben Gamari—[PATCH 2/4] compact: Give user more feedback on failure renaming [inbox, notmuch::obsolete, notmuch::patch, unread]
- Ben Gamari—[PATCH 3/4] compact: Provide user with more error feedback [inbox, notmuch::obsolete, notmuch::patch, unread]
- Ben Gamari—[PATCH 4/4] database: Handle error while deleting uncompacted database [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 4/4] database: Handle error while deleting uncompacted database [inbox, unread]
    - Ben Gamari—Re: [PATCH 4/4] database: Handle error while deleting uncompacted database [inbox, signed, unread]
- Tomi Ollila—Re: [PATCH 1/4] test: Add compact test [inbox, unread]
  - Ben Gamari—Re: [PATCH 1/4] test: Add compact test [inbox, signed, unread]