Re: [PATCH v2 2/5] compact: catch Xapian::Error consistently

Subject: Re: [PATCH v2 2/5] compact: catch Xapian::Error consistently

Date: Sun, 17 Nov 2013 20:33:33 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

> catch Xapian::Error in compact code in lib/database.cc to be consistent
> with other code in addition to not making software crash on uncaught
> other Xapian error.

pushed the first two patches

d

• Previous message (by thread): Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

Thread:

• Tomi Ollila—compactor adjustments v2 [inbox, unread]
  • Tomi Ollila—[PATCH v2 1/5] compact: tidy formatting [inbox, notmuch::patch, notmuch::pushed, unread]
  • Tomi Ollila—[PATCH v2 2/5] compact: catch Xapian::Error consistently [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—Re: [PATCH v2 2/5] compact: catch Xapian::Error consistently [inbox, unread]
    • David Bremner—Re: [PATCH v2 2/5] compact: catch Xapian::Error consistently [inbox, unread]
  • Tomi Ollila—[PATCH v2 3/5] compact: preserve backup database until compacted database is in place [inbox, unread]
    • Jani Nikula—Re: [PATCH v2 3/5] compact: preserve backup database until compacted database is in place [inbox, unread]
  • Tomi Ollila—[PATCH v2 4/5] compact: unconditionally attempt to remove old wip database compact directory [inbox, unread]
    • Jani Nikula—Re: [PATCH v2 4/5] compact: unconditionally attempt to remove old wip database compact directory [inbox, unread]
  • Tomi Ollila—[PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
    • Jani Nikula—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
      • David Bremner—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
        • Tomi Ollila—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
          • David Bremner—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
            • Tomi Ollila—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]
              • David Bremner—Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures [inbox, unread]