Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

Subject: Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

Date: Sun, 17 Nov 2013 20:53:38 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:
> I was thinking naming the function notmuch_database_compact_internal ()
> as one option (I also though of notmuch_database_compact_unstable () -- but
> that sounds so "unstable" (at least outside Debian people ;D)) --
> could be one option. Then developers should understand the API is not
> fixed there...

I think 0.18 will just be an API breaking release in general; compact is
probably the least of people's worries. Yes, it's a bit more irritating
because the API will be short lived, but since we plan to change
notmuch_database_open, pretty much every client of the library will have
to update anyway. Luckily there probably aren't enough such clients to
get a really good lynch mob together.  I'd suggest just mentioning it
NEWS for 0.17 that the library interface for compact is expected to
change in 0.18.

d

Thread: