Re: [PATCH v2 1/2] test: uncaught exception when editing properties of a removed message

Subject: Re: [PATCH v2 1/2] test: uncaught exception when editing properties of a removed message

Date: Wed, 29 Mar 2023 07:42:55 -0300

To: Kevin Boulain, notmuch@notmuchmail.org

Cc:

From: David Bremner

Kevin Boulain <kevin@boula.in> writes:

> +== stderr ==
> +A Xapian exception occurred at message-property.cc:XXX: No termlist for document 54
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
> +
> +add_email_corpus

Hi Kevin;

Thanks for the speedy update. I hate to do this but I think the message
is now _too_ specific. Goldilocks and the three tests I guess.

In particular, is there some reason to think that the number 54 is
stable here? I'm worried about the test being flaky if there is some
Xapian related change. Maybe just sed the number away?

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH v3 1/2] test: uncaught exception when editing properties of a removed message

Thread:

• Kevin Boulain—[PATCH 1/2] test: uncaught exception when editing properties of a removed message [inbox, notmuch::obsolete, notmuch::patch, notmuch::pushed, unread]
  • Kevin Boulain—[PATCH 2/2] lib/message-property: catch xapian exceptions [inbox, notmuch::moreinfo, notmuch::obsolete, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 2/2] lib/message-property: catch xapian exceptions [inbox, unread]
      • Kevin Boulain—[PATCH v2 1/2] test: uncaught exception when editing properties of a removed message [inbox, notmuch::moreinfo, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH v2 1/2] test: uncaught exception when editing properties of a removed message [inbox, unread]
          • Kevin Boulain—[PATCH v3 1/2] test: uncaught exception when editing properties of a removed message [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—Re: [PATCH v3 1/2] test: uncaught exception when editing properties of a removed message [inbox, unread]
          • Kevin Boulain—[PATCH v3 2/2] lib/message-property: catch xapian exceptions [inbox, notmuch::patch, notmuch::pushed, unread]
          • Kevin Boulain—Re: [PATCH v2 1/2] test: uncaught exception when editing properties of a removed message [inbox, unread]
      • Kevin Boulain—[PATCH v2 2/2] lib/message-property: catch xapian exceptions [inbox, notmuch::moreinfo, notmuch::patch, unread]
      • Kevin Boulain—Re: [PATCH 2/2] lib/message-property: catch xapian exceptions [inbox, unread]