Re: [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix

Subject: Re: [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix

Date: Thu, 30 Mar 2023 08:25:20 -0300

To: Kevin Boulain, notmuch@notmuchmail.org

Cc:

From: David Bremner

Kevin Boulain <kevin@boula.in> writes:

> It wasn't covered, though it shares most of its implementation with
> notmuch_message_remove_all_properties.

I have applied this series to master, with one commit added in the
middle

commit 336334996750240608d5f29ed5dd8e40a69c4d79
Author: David Bremner <david@tethera.net>
Date:   Thu Mar 30 07:56:17 2023 -0300

    test: reveal notmuch_message_remove_all_properties as broken
    
    Close and re-open the database to show that the removal is not
    committed to the database.

I also had to manually deal with a merge conflict for the last patch, so
you might want to double check that.

In my next life, I will make more liberal use of backup_database /
restore_database, to make the tests in this file less order dependent.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: