Re: [PATCH 2/2] lib/message-property: sync removed properties to the database

Subject: Re: [PATCH 2/2] lib/message-property: sync removed properties to the database

Date: Wed, 29 Mar 2023 08:32:16 -0300

To: Kevin Boulain

Cc: notmuch@notmuchmail.org

From: David Bremner


Kevin Boulain <kevin@boula.in> writes:

> On 2023-03-03 at 00:39 +02, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> Somehow testkey1 = testvalue1 disappeared from the test code (which is
>> probably expected -- perhaps the commit message of the *change* 1/2
>> tried to point to that ;D)
>
> Yes, that proves notmuch_message_remove_all_properties is broken without
> the patch. The eponymous test gave the impression the property had been
> removed (stdout is empty) but I believe this is only due to
> _notmuch_message_invalidate_metadata. Now the "dump message properties"
> test doesn't list it anymore, which is what I expect.

It would be nice to structure this in terms of a known broken test
(perhaps modify the existing one to reopen the database and dump the properties)
that is then fixed by patch adding the sync.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: