Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

Subject: Re: [PATCH v2] emacs: Pass a copy to notmuch-saved-search-sort-function

Date: Mon, 05 Mar 2012 22:08:39 +0100

To: Jani Nikula, Dmitry Kurochkin

Cc: notmuch@notmuchmail.org

From: Daniel Schoepe


On Mar 5, 2012 5:43 PM, "Dmitry Kurochkin" <dmitry.kurochkin@gmail.com>
> I do not buy the argument that we should help users who implement their
> own sorting functions but do not read documentation for functions they
> use.  Apparently, those who implemented the `sort' function had similar
> ideas.  And I do not think it is our job to add workarounds for it.

Yeah that also sounds a bit more consistent, I guess my perception was
colored by my surprise at learning that sort has side effects in elisp. :)

On Mon, 5 Mar 2012 22:55:54 +0200, Jani Nikula <jani@nikula.org> wrote:
> Providing the customization of the sort function is more powerful than the
> compare function. In the case of saved searches I can imagine people might
> want to partially use the original order while sort the rest (e.g.
> important ones first in predefined order, others sorted). In fact this also
> allows dropping out some elements. And renaming. And changing the queries...
> 
> (I had something like that in mind originally but then settled with just
> capitalizing the important ones to show them first.)

I have the same objections to only providing a customization option for
comparing.

Cheers,
Daniel
part-000.sig (application/pgp-signature)

Thread: