Re: [PATCH v2] nmbug: write tags out to a temporary file, not 'nmbug.index'

Subject: Re: [PATCH v2] nmbug: write tags out to a temporary file, not 'nmbug.index'

Date: Sun, 13 Feb 2022 12:17:09 -0500

To: Sean Whitton

Cc: notmuch@notmuchmail.org

From: Kyle Meyer

[ drive-by comment based on a past mistake :/ ]

Sean Whitton writes:

> -def _index_tags():
> -    "Write notmuch tags to the nmbug.index."
> -    path = _os.path.join(NMBGIT, 'nmbug.index')
> +    (_, index) = _tempfile.mkstemp()
[...]
>      _git(
>          args=['read-tree', '--empty'],
> -        additional_env={'GIT_INDEX_FILE': path}, wait=True)
> +        additional_env={'GIT_INDEX_FILE': index}, wait=True)

It's better to put the temporary index in $GIT_DIR due to this bit noted
in git-read-tree(1):

      The file must allow to be rename(2)ed into from a temporary file
      that is created next to the usual index file; typically this means
      it needs to be on the same filesystem as the index file itself, and
      you need write permission to the directories the index file and
      index output file are located in.

So, assuming NMBGIT matches $GIT_DIR, perhaps change the above mkstemp
call to something like

  _tempfile.mkstemp(dir=NMBGIT, prefix="nmbug", suffix=".index")
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: