Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations

Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations

Date: Sun, 25 Mar 2012 08:24:42 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner


On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
> To simplify code, keep all tagging operations in a single array
> instead of separate add and remove arrays. Apply tag changes in the
> order specified on the command line, instead of first removing and
> then adding the tags.

Like I said on IRC, my only minor reservation with this patch is that
the use of C99 struct assignment is maybe not a good tradeoff here,
since it makes the code a bit more mysterious (for the great unwashed
masses that don't know C99 as well as C89). Still, if you think extra
initialization features are worth it, I can live with it. 

d

Thread: