Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function

Subject: Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function

Date: Sun, 25 Mar 2012 10:33:42 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Sat, 24 Mar 2012 18:14:37 +0200, Jani Nikula <jani@nikula.org> wrote:
> Refactor to make tagging code easier to reuse in the future. No
> functional changes.

The second two look OK as well.  It isn't obvious to me that in the long
term we want an API using "file_tags" to pass in a string. It reminds me
of the term "stringly typed". Of course, I see why it is this way in an
intial refactor, but maybe something to think about before we start
propagating such an API.

d

• Previous message (by thread): Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function

Thread:

• Jani Nikula—[PATCH 0/3] cli: notmuch tag/restore refactoring [inbox, unread]
  • Jani Nikula—[PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations [inbox, unread]
    • David Bremner—Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations [inbox, unread]
  • Jani Nikula—[PATCH 2/3] cli: refactor "notmuch tag" query tagging into a separate function [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 3/3] cli: refactor "notmuch restore" message tagging into a separate function [inbox, unread]