Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t

Subject: Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t

Date: Fri, 18 May 2012 12:17:49 -0700

To: Austin Clements

Cc: Notmuch Mail

From: Jameson Graef Rollins

On Fri, May 18 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>> -		(GMIME_MULTIPART_SIGNED (part), node->ctx->cryptoctx, &err);
>> +		(GMIME_MULTIPART_SIGNED (part), node->ctx->crypto.gpgctx, &err);
>
> This should be crypto->gpgctx.

Weird.  Good catch, Austin!  But I must admit I'm thoroughly confused.
I tested every stage of this series right before I sent, and sure enough
this patch compiles cleanly and all tests pass.  Can anyone explain why?
I don't understand.  I'll send a new version of this one patch now
anyway.

jamie.

• Previous message (by thread): Re: [PATCH v2 4/5] cli: new crypto verify flag to handle verification

Thread:

• Jameson Graef Rollins—[PATCH v2 0/5] cli: improve handling of crypto parameters and contexts [inbox, unread]
  • Jameson Graef Rollins—[PATCH v2 1/5] cli: new crypto structure to store crypto contexts and parameters [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—[PATCH v2 2/5] cli: modify mime_node_open to take crypto struct as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH v2 4/5] cli: new crypto verify flag to handle verification [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Austin Clements—Re: [PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed [inbox, notmuch::review, unread]
              • Jameson Graef Rollins—Re: [PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed [inbox, signed, unread]
                • Daniel Kahn Gillmor—Re: [PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed [inbox, signed, unread]
                  • Jameson Graef Rollins—Re: [PATCH v2 5/5] cli: lazily create the crypto gpg context only when needed [inbox, signed, unread]
          • Jani Nikula—Re: [PATCH v2 4/5] cli: new crypto verify flag to handle verification [inbox, notmuch::review, unread]
            • Jameson Graef Rollins—Re: [PATCH v2 4/5] cli: new crypto verify flag to handle verification [inbox, signed, unread]
        • Austin Clements—Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t [inbox, notmuch::review, unread]
          • Jameson Graef Rollins—Re: [PATCH v2 3/5] cli: modify mime_node_context to use the new notmuch_crypto_t [inbox, signed, unread]