Re: [PATCH 07/10] Define new config option index.try_decrypt

Subject: Re: [PATCH 07/10] Define new config option index.try_decrypt

Date: Tue, 12 Sep 2017 19:29:33 -0400

To: Notmuch Mail

Cc:

From: Daniel Kahn Gillmor

On Tue 2017-09-12 19:01:50 -0400, Daniel Kahn Gillmor wrote:
> By default, notmuch won't try to decrypt on indexing.  With this
> patch, we make it possible to indicate a per-database preference using
> the config variable "index.try_decrypt", which by default will be
> false.

I've just discovered that this particular patch doesn't work properly.

Despite doing "notmuch config set index.try_decrypt true", i get the
empty string when i invoke (in C): notmuch_config_get(db,
"index.try_decrypt").

I think that means i've misunderstood the notmuch config subsystem,
unfortunately.  I would be happy to hear any suggestions for what i
should be doing differently!

The rest of the series should still hold up, though.

    --dkg

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH v3 11/15] config: indexing defaults will be stored in the database.

Thread:

• Daniel Kahn Gillmor—[PATCH 01/10] reorganize indexing of multipart/signed and multipart/encrypted [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 02/10] crypto: Move crypto.c into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 03/10] crypto: make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 04/10] tests: prepare for more crypto tests (using add_gnupg_home) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 05/10] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 06/10] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 07/10] Define new config option index.try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 07/10] Define new config option index.try_decrypt [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH 08/10] add --try-decrypt=(true|false) to notmuch new [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 09/10] add --try-decrypt=(true|false) to notmuch insert [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 10/10] add --try-decrypt=(true|false) to notmuch reindex [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—cleartext-indexing [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 01/10] crypto: Move crypto.c into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 01/10] crypto: Move crypto.c into libutil [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 02/10] crypto: make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 02/10] crypto: make shared crypto code behave library-like [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v2 02/10] crypto: make shared crypto code behave library-like [inbox, signed, unread]
      • Daniel Kahn Gillmor—[PATCH v2 03/10] tests: prepare for more crypto tests (using add_gnupg_home) [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 03/10] tests: prepare for more crypto tests (using add_gnupg_home) [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 04/10] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 04/10] index: implement notmuch_indexopts_t with try_decrypt [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v2 04/10] index: implement notmuch_indexopts_t with try_decrypt [inbox, signed, unread]
            • Jani Nikula—Re: [PATCH v2 04/10] index: implement notmuch_indexopts_t with try_decrypt [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 05/10] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 05/10] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v2 05/10] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 06/10] config: indexing defaults will be stored in the database. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Daniel Kahn Gillmor—[PATCH v2 07/10] config: define new option index.try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 07/10] config: define new option index.try_decrypt [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 08/10] cli/new: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jani Nikula—Re: [PATCH v2 08/10] cli/new: add --try-decrypt=(true|false) [inbox, unread]
      • Daniel Kahn Gillmor—[PATCH v2 09/10] cli/insert: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Daniel Kahn Gillmor—[PATCH v2 10/10] cli/reindex: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Daniel Kahn Gillmor—cleartext indexing, round 3 [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 01/15] crypto: rename notmuch_crypto_t to _notmuch_crypto_t [inbox, notmuch::patch, notmuch::pushed, unread]
        • Daniel Kahn Gillmor—[PATCH v3 02/15] crypto: drop pretense of notmuch_crypto_context_t [inbox, notmuch::patch, notmuch::pushed, unread]
        • Daniel Kahn Gillmor—[PATCH v3 03/15] crypto: _notmuch_crypto_cleanup should return void [inbox, notmuch::patch, notmuch::pushed, unread]
        • Daniel Kahn Gillmor—[PATCH v3 04/15] crypto: move into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—Re: [PATCH v3 04/15] crypto: move into libutil [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH v3 04/15] crypto: move into libutil [inbox, signed, unread]
              • David Bremner—Re: [PATCH v3 04/15] crypto: move into libutil [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 05/15] gmime-extra: remove duplicate GMimeAddressType typedef [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
        • Daniel Kahn Gillmor—[PATCH v3 06/15] crypto: make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Daniel Kahn Gillmor—[PATCH v3 07/15] tests: prepare for more crypto tests (using add_gnupg_home) [inbox, notmuch::patch, notmuch::pushed, unread]
        • Daniel Kahn Gillmor—[PATCH v3 08/15] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Daniel Kahn Gillmor—avoid double typedef [inbox, unread]
            • Daniel Kahn Gillmor—[PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Bremner—Re: [PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt [inbox, unread]
                • Daniel Kahn Gillmor—Re: [PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt [inbox, signed, unread]
            • Tomi Ollila—Re: avoid double typedef [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 09/15] gmime-extra: drop compat layer for g_mime_multipart_encrypted_decrypt [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—Re: [PATCH v3 09/15] gmime-extra: drop compat layer for g_mime_multipart_encrypted_decrypt [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, signed, unread]
              • David Bremner—Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, unread]
              • David Bremner—Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 11/15] config: indexing defaults will be stored in the database. [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—Re: [PATCH v3 11/15] config: indexing defaults will be stored in the database. [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH v3 11/15] config: indexing defaults will be stored in the database. [inbox, unread]
        • Daniel Kahn Gillmor—[PATCH v3 12/15] config: define new option index.try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Daniel Kahn Gillmor—[PATCH v3 13/15] cli/new: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Daniel Kahn Gillmor—[PATCH v3 14/15] cli/insert: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Daniel Kahn Gillmor—[PATCH v3 15/15] cli/reindex: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—Re: cleartext indexing, round 3 [inbox, signed, unread]
          • Daniel Kahn Gillmor—Re: cleartext indexing, round 3 [inbox, signed, unread]
        • David Bremner—Re: cleartext indexing, round 3 [inbox, unread]