Re: [PATCH] Fix notmuch-mua.el notmuch-mua-mail

Subject:Re: [PATCH] Fix notmuch-mua.el notmuch-mua-mail

Date:Wed, 01 Jun 2022 21:57:26 +0200

To:David Bremner ,notmuch@notmuchmail.org

Cc:

From:Damien Cassou


Hi David,

David Bremner <david@tethera.net> writes:
> If possible, please use git-send-email, as it makes applying the patches
> easier.


I've sent a new version in <20220601195048.166397-1-damien@cassou.me>. I
hope I followed all recommendations. If I didn't, please tell me so I
can do better next time.

Can you please explain me what in git-send-email makes it easier to
apply the patches? I'm also interested in your process to apply patches
from your mua (notmuch in Emacs hopefully) to your git repository.

> Our conventions for commit messages are different than emacs [1], we
> don't list filenames in the commit message but we do usually list the
> "subsystem" in the subject [2]


I'm sorry I completely forgot to have a look at the conventions before
sending.

> I think the cursor positioning behaviour should be documented in the
> function docstring. 


done


> [1]: It might be a personal issue, but the emacs commit message style
> really annoys me.


I also don't like it. I think it focuses too much on what has changed
(something that could be inferred from the patch with a little tooling)
instead of why the code has changed this way (something only the author
can tell).

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: