On Fri, 06 Apr 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote: > On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote: >> This is the latest version of the patch series (previous version at [1]). >> I think this version fixes all the problems raised by Austin in his review. > > Tested and reviewed and LGTM. > > Unfortunately, though, I just now noticed that the tests don't cover > count and show excludes. Since everything else looks good, let's just > make a new version of [0]. I suggest we name the new test script just > "excludes" and then add count and show tests there. That should be > pretty straightforward. There are some exclude tests for count in test/count. Do you think it needs to be a full test everything like in test/search-exclude? There aren't any tests for show exclude, but there aren't very many tests explicitly for show anyway. My preference would be to add something like id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add some tests to that. I could add some tests for show-excludes in the same format as the search-exclude tests though if you think that is better. Best wishes Mark > > Thanks again, Mark. > > jamie. > > [0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com"