Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

Date: Fri, 06 Apr 2012 08:13:59 -0700

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is the latest version of the patch series (previous version at [1]).
> I think this version fixes all the problems raised by Austin in his review.

Tested and reviewed and LGTM.

Unfortunately, though, I just now noticed that the tests don't cover
count and show excludes.  Since everything else looks good, let's just
make a new version of [0].  I suggest we name the new test script just
"excludes" and then add count and show tests there.  That should be
pretty straightforward.

Thanks again, Mark.

jamie.

[0] id:"1333716551-29153-5-git-send-email-markwalters1009@gmail.com"
part-000.sig (application/pgp-signature)

Thread: