Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Date: Sat, 01 Sep 2012 23:38:09 -0300

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: David Bremner


Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:

> Before the change, test_expect_equal_file() function treated the first
> argument as "actual output file" and the second argument as "expected
> output file".  When the test fails, the files are copied for later
> inspection.  The first files was copied to "$testname.output" and the
> second file to "$testname.expected".  The argument order for
> test_expect_equal_file() is often wrong which results in confusing
> diff output and incorrectly named files.

pushed, 

d

Thread: