Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Date: Thu, 02 Feb 2012 14:33:56 +0000

To: Jameson Graef Rollins, Dmitry Kurochkin, Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Edmondson

On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> If this is really a problem, I vote for 1.  In general, I am not in
> favor of making the test suite more complicated than it needs to be.

After listening to the debate, I agree. The documentation should state
that the order is 'expected actual' (or the other way around) and
offenders should be shot on sight^W^W^Wfixed.

• Previous message (by thread): Re: [PATCH] test: make test_expect_equal_file() arguments flexible

Thread:

• Dmitry Kurochkin—[PATCH] test: make test_expect_equal_file() arguments flexible [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
  • David Edmondson—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, notmuch::review, signed, unread]
  • Jameson Graef Rollins—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, signed, unread]
    • Tomi Ollila—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
    • Dmitry Kurochkin—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
      • Tomi Ollila—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
        • Dmitry Kurochkin—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, signed, unread]
            • Dmitry Kurochkin—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
              • Dmitry Kurochkin—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
            • David Edmondson—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, signed, unread]
              • Tomi Ollila—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]
  • Jameson Graef Rollins—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, signed, unread]
  • David Bremner—Re: [PATCH] test: make test_expect_equal_file() arguments flexible [inbox, unread]