Re: [PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

Subject: Re: [PATCH 4/4] Add CONFIGURE_LDFLAGS to the notmuch-shared buld command line.

Date: Wed, 14 Apr 2010 11:04:11 -0700

To: Aaron Ecay, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Sun, 11 Apr 2010 19:44:54 -0400, Aaron Ecay <aaronecay@gmail.com> wrote:
> Otherwise, symbol not found errors result on OS X.  I am not sure
> this is the correct solution for the problem, but it gets the build
> working.
...
> -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch
> +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS)
>  FINAL_LIBNOTMUCH_LDFLAGS = $(LDFLAGS) $(CONFIGURE_LDFLAGS)

As I mentioned earlier in the thread, this isn't the correct solution
for Linux. Previously we had just FINAL_LDFLAGS that were used for both
the binary and the library. We split this into FINAL_NOTMUCH_LDFLAGS and
FINAL_LIBNOTMUCH_LDFLAGS precisely to avoid excess library dependencies
on Linux.

So the above patch would undo that which is not what we want.

-Carl
part-000.sig (application/pgp-signature)

Thread: