Re: [PATCH 3/4] Add infrastructure for building shared library on OS X.

Subject: Re: [PATCH 3/4] Add infrastructure for building shared library on OS X.

Date: Wed, 14 Apr 2010 11:47:12 -0700

To: Aaron Ecay, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Wed, 14 Apr 2010 11:01:58 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Sun, 11 Apr 2010 19:44:53 -0400, Aaron Ecay <aaronecay@gmail.com> wrote:
> > -include $(subdirs:%=%/Makefile.local) Makefile.local
> > +include Makefile.config $(subdirs:%=%/Makefile.local) Makefile.local
> 
> This first hunk looks unrelated to what's described in the commit
> message.

Indeed, on further testing this looks like it should have been part of
the previous commit that includes the sub-directory Makefile.local files
before the top-level Makefile.local. Without this piece, I was seeing
the various compat/*.c files being compiled unconditionally.

> But I'd be willing to accept that if necessary---should just remove the
> include of Makefile.config from Makefile.local then I think.

I've gone ahead and done that now. I moved everything concerning
Makefile.config, (dependency, include, and generation), from
Makefile.local up to the top-level Makefile.

-Carl
part-000.sig (application/pgp-signature)

Thread: