Re: [PATCH 2/4] insert: strip trailing / in folder path

Subject: Re: [PATCH 2/4] insert: strip trailing / in folder path

Date: Sat, 19 Aug 2017 09:55:00 -0300

To: Yuri Volchkov,


From: David Bremner

Yuri Volchkov <> writes:

> This is just for consistency reasons. Fixing my problem required the
> same piece of code, which was used here. Duplicating is not nice, so I
> made a function around this code. That's why it feels atomic change
> to me.
> I think, explanation like this is superfluously detailed.
> I can move the introduction of the strip_trailing and cleaning
> notmuch_database_open_verbose into separate patch, but the fix then will
> be just a one line. And I'll get unnecessarily tiny patches.

I prefer the smaller commits in case there is some unforseen effect of
changing notmuch_database_open_verbose; it makes it easier to use git
bisect. As a commit message, it almost suffices to mention reducing code
duplication, although do note this is really a change in beheviour: your
new code strips multiple trailing /, while the old code did not.

notmuch mailing list