Re: cleartext indexing, revision 6

Subject: Re: cleartext indexing, revision 6

Date: Fri, 20 Oct 2017 08:14:26 -0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> This is the 6th revision of the cleartext indexing series.
>
> It differs from the 5th mainly in minor edits: fixing typos and
> improving comments, documentation, and commit messages.  It also has
> the following (slightly more) significant changes:

My review of this series is complete.

I've pushed 3 of these patches, marked 5 as notmuch::moreinfo, meaning
some (possibly ignorable) comment sent, and marked 6 as notmuch::stale,
meaning they have been reviewed, but don't apply because of missing
patches.

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: cleartext indexing, revision 6

Thread:

• Daniel Kahn Gillmor—cleartext indexing, revision 6 [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v6 01/14] crypto: move into libnotmuch_util [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v6 02/14] crypto: make shared crypto code behave library-like [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v6 03/14] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v6 03/14] index: implement notmuch_indexopts_t with try_decrypt [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v6 04/14] doc: add notmuch-properties(7) [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—Re: [PATCH v6 04/14] doc: add notmuch-properties(7) [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH v6 05/14] properties: add notmuch_message_remove_all_properties_with_prefix() [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v6 06/14] reindex: drop all properties named with prefix "index." [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v6 06/14] reindex: drop all properties named with prefix "index." [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v6 06/14] reindex: drop all properties named with prefix "index." [inbox, signed, unread]
    • David Bremner—Re: [PATCH v6 06/14] reindex: drop all properties named with prefix "index." [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v6 06/14] reindex: drop all properties named with prefix "index." [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v6 07/14] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v6 08/14] config: store index.try_default in the database. [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v6 09/14] config: define new option index.try_decrypt [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v6 10/14] cli: set up shared command-line arguments for indexing [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v6 10/14] cli: set up shared command-line arguments for indexing [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v6 11/14] tests: emacs_fcc_message: allow passing --arguments to notmuch new [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v6 12/14] cli/new: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v6 13/14] cli/insert: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v6 13/14] cli/insert: add --try-decrypt=(true|false) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v6 14/14] cli/reindex: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
  • David Bremner—Re: cleartext indexing, revision 6 [inbox, unread]