Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > + ret = notmuch_message_remove_all_properties_with_prefix (message, "index."); > + if (ret) { > + INTERNAL_ERROR ("failed to remove index.* properties"); > + goto DONE; > + } 1) INTERNAL_ERROR is fatal, so the goto is unneeded / confusing. 2) Is there no sensible return value here? The function already has an error return path. I see there is one INTERNAL_ERROR there so maybe similar reasoning applies and a TODO is enough. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch