Re: [PATCH] WIP: sort top level messages in thread

Subject: Re: [PATCH] WIP: sort top level messages in thread

Date: Tue, 28 Aug 2018 17:33:32 -0400

To: Gregor Zattler, notmuch@notmuchmail.org

Cc:

From: Amin Bandali

Hi Gregor, David,

> The patch applied cleanly on top of the others (which I use
> regularly with no problems) and fixed the threading order problem
> in the two test cases I send you.  Other RT-emails are also
> ordered nicely now.
>
> Thanks for this patch, I'll also use it regularly.

Seconded.  Thanks for your work on the patch, David.  It seems to
nicely order my RT tickets too, including the very first message
in each thread.

I'll continue using the patch and will report back if I run into
any issues.

-amin
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH] WIP: sort top level messages in thread

Thread:

• David Bremner—Threading patches v2 [inbox, unread]
  • David Bremner—[PATCH 01/15] util: add DEBUG_PRINTF, rename error_util.h -> debug_print.h [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 02/15] test: start threading test corpus [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 03/15] test: add known broken tests for "ghost roots" [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 04/15] lib/thread: sort child messages by date [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 05/15] lib: read reference terms into message struct. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 06/15] lib/thread: refactor in-reply-to test. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 07/15] lib: calculate message depth in thread [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 08/15] lib/thread: rewrite _parent_or_toplevel to use depths [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 09/15] lib/thread: change _resolve_thread_relationships to use depths [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 10/15] test: add known broken test for good In-Reply-To / bad References [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 11/15] test/thread-replies: mangle In-Reply-To's [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 12/15] util/string-util: export skip_space [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 13/15] lib: add _notmuch_message_id_parse_strict [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Amin Bandali—Re: [PATCH 13/15] lib: add _notmuch_message_id_parse_strict [inbox, unread]
    • David Bremner—[Patch v1.1] lib: add _notmuch_message_id_parse_strict [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 14/15] lib: change parent strategy to use In-Reply-To if it looks sane [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 15/15] test: add known broken test for multiple thread terms per message [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Gregor Zattler—Re: Threading patches v2 [inbox, unread]
    • David Bremner—[PATCH] WIP: sort top level messages in thread [inbox, unread]
      • Gregor Zattler—Re: [PATCH] WIP: sort top level messages in thread [inbox, unread]
        • Amin Bandali—Re: [PATCH] WIP: sort top level messages in thread [inbox, unread]