Re: [bug] notmuch requires Content-Disposition mime header value to be lower case

Subject:Re: [bug] notmuch requires Content-Disposition mime header value to be lower case

Date:Fri, 18 Sep 2015 09:03:20 -0300

To:Johannes Schauer ,notmuch@notmuchmail.org

Cc:

From:David Bremner


Johannes Schauer <josch@debian.org> writes:


> Funnily though there seem to be some weird newline differences that I cannot
> explain, so I left them for somebody else to fix.
>

Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart,
there's more than whitespace changes. Some things that used to marked
"attachment" in the output are now marked "part".

> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh
> index 7c4c9f7..f16cc90 100755
> --- a/test/T190-multipart.sh
> +++ b/test/T190-multipart.sh
> @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart
>  cat <<EOF >> ${MAIL_DIR}/multipart
>  
>  --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>  
>  This is a text attachment.
>  
> @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part.
>  --==-=-==--
>  
>  --=-=-=
> -Content-Disposition: attachment; filename=attachment
> +Content-Disposition: ATTACHMENT; FILENAME=attachment
>  
>  This is a text attachment.
>  

I'd recommend making your own new test, rather than modifying existing
ones to test multiple things.  I'd also recommend using json / sexp
output for your tests, since the ad-hoc text format is kindof
semi-deprecated.

d

Thread: