Re: [PATCH 1/2] lib: content disposition values are not case-sensitive

Subject: Re: [PATCH 1/2] lib: content disposition values are not case-sensitive

Date: Thu, 19 Nov 2015 07:57:11 -0400

To: Jani Nikula, Johannes Schauer, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> Per RFC 2183, the values for Content-Disposition values are not
> case-sensitive. While at it, use the gmime function for getting at the
> disposition string instead of referencing the field directly.

I pushed these two, along with the working test from my patch.

If someone actually has a fix for the other test, we can return to
discussing whether it's a bug or not.

d

• Previous message (by thread): Re: [PATCH 1/2] lib: content disposition values are not case-sensitive

Thread:

• Johannes Schauer—Re: [bug] notmuch requires Content-Disposition mime header value to be lower case [attachment, inbox, signed, unread]
  • David Bremner—Re: [bug] notmuch requires Content-Disposition mime header value to be lower case [inbox, unread]
    • Johannes Schauer—Re: [bug] notmuch requires Content-Disposition mime header value to be lower case [inbox, signed, unread]
      • David Bremner—Re: [bug] notmuch requires Content-Disposition mime header value to be lower case [inbox, unread]
        • Jani Nikula—Re: [bug] notmuch requires Content-Disposition mime header value to be lower case [inbox, unread]
        • Jani Nikula—[PATCH 1/2] lib: content disposition values are not case-sensitive [inbox, notmuch::patch, notmuch::pushed, unread]
          • Jani Nikula—[PATCH 2/2] cli: content disposition values are not case-sensitive [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—[WIP] tests: add test for case insensitive Content-Disposition [inbox, notmuch::bug, notmuch::patch, notmuch::wip, unread]
              • Jani Nikula—Re: [WIP] tests: add test for case insensitive Content-Disposition [inbox, unread]
                • Johannes Schauer—Re: [WIP] tests: add test for case insensitive Content-Disposition [inbox, signed, unread]
          • David Bremner—Re: [PATCH 1/2] lib: content disposition values are not case-sensitive [inbox, unread]