Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Subject: Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Date: Tue, 18 Oct 2011 08:16:12 -0700

To: Thomas Schwinge

Cc: Notmuch Mail

From: Jameson Graef Rollins

On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
> On Sun,  9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> >  (defun notmuch-show-get-message-id ()
> >    "Return the message id of the current message."
> > -  (concat "id:\"" (notmuch-show-get-prop :id) "\""))
> > +  (concat "\"" (notmuch-show-get-prop :id) "\""))
> 
> Shouldn't the double quotes be removed here, too?  (And be re-added in
> the other places where id: is added.)

Yes, I think you're right Thomas.  Afaik emacs doesn't need any kind of
escaping when storing strings internally.  I'll tweak that and resubmit
the patch.

jamie.

• Previous message (by thread): Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Thread:

• Jameson Graef Rollins—[PATCH] NEWS: add notes about emacs improvements and reply formating cleanup [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  • Jameson Graef Rollins—Re: [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup [inbox, notmuch::emacs, signed, unread]
    • Thomas Schwinge—Re: [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup [inbox, notmuch::emacs, signed, unread]
      • Jameson Graef Rollins—Re: [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup [inbox, notmuch::emacs, signed, unread]
    • Jameson Graef Rollins—[PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
      • Thomas Schwinge—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, signed, unread]
        • Jameson Graef Rollins—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, signed, unread]
        • Jameson Graef Rollins—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, signed, unread]
          • Tomi Ollila—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, unread]
          • Daniel Schoepe—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, signed, unread]
            • Tomi Ollila—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, unread]
      • David Bremner—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". [inbox, signed, unread]
  • David Bremner—Re: [PATCH] NEWS: add notes about emacs improvements and reply formating cleanup [inbox, unread]