Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Subject: Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:".

Date: Wed, 26 Oct 2011 19:52:59 -0700

To: Thomas Schwinge

Cc: Notmuch Mail

From: Jameson Graef Rollins


On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
> On Sun,  9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> >  (defun notmuch-show-get-message-id ()
> >    "Return the message id of the current message."
> > -  (concat "id:\"" (notmuch-show-get-prop :id) "\""))
> > +  (concat "\"" (notmuch-show-get-prop :id) "\""))
> 
> Shouldn't the double quotes be removed here, too?  (And be re-added in
> the other places where id: is added.)

In point of fact, do we need these quotes around message IDs at all?
Can message IDs have characters that would need to be escaped for the
shell?

This seems to also be related to the issue brought up by Erlend Simonsen
in [0], where emacs 24 seems to be shell-quoting things as needed.

So maybe these quotes aren't actually needed at all?...

jamie.

[0] id:87y5w9w6dm.fsf@fudge.hue.no
part-000.sig (application/pgp-signature)

Thread: