Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email

Subject: Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email

Date: Sun, 14 Aug 2016 08:43:47 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Shea Levy


Hi Jani,

Jani Nikula <jani@nikula.org> writes:

> On Tue, 09 Aug 2016, Shea Levy <shea@shealevy.com> wrote:
>> Currently, while notmuch-reply will recognize email addresses other than
>> the main address with user.other_email, it always sets the name part of
>> the address in the envelope-from and From headers to user.name. This
>> patchset enables specifying names on a per-address basis with a new
>> user.other_name property. Presumably other users of user.other_email
>> may want to use this as well, but those are not updated currently.
>
> I am not convinved by adding another configuration option, especially
> when it has to be in sync with another configuration option (ordering in
> user.other_name having to match user.other_email). I would much prefer
> allowing (but not requiring) "Name <user@example.org>" style addresses
> both in user.primary_email and user.other_email.
>

This would be fine with me. Is there already code in place to separate
out the name and email values from that kind of email address?

>
> With a cursory glance at the implementation, I wonder if you could just
> pick the name based on the address you've picked earlier, and leave the
> address matching mostly as it is. Would save some passing of parameters
> around. Maybe.
>

Hmm, I'm not sure what you mean by this, sorry. Can you expand?

>
> Additionally, I'd very much like to have my series [1] merged
> first. It'll be *much* easier to rebase your series on top than the
> other way around...
>

Happy to rebase my work on yours.

>
> BR,
> Jani.
>
>
> [1] id:cover.1471088022.git.jani@nikula.org

Thread: