Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys

Subject: Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys

Date: Fri, 08 Dec 2017 02:03:05 -0500

To: Jameson Graef Rollins, David Bremner, Notmuch Mail

Cc:

On Thu 2017-12-07 00:20:12 -0800, Jameson Graef Rollins wrote:
> On Mon, Dec 04 2017, David Bremner <david@tethera.net> wrote:
>> Pushed patches 1 to 6. I seem to recall 7 and 8 basically adressed
>> concerns/suggestions Jamie had, so I'm hoping he can have a quick look
>> at those.
>
> Yes, this new series is great and definitely addresses all my concerns.
> I'm stoked to see that the first part of it has been pushed, and looking
> forward to the full series!
>
> This is really great progress, Daniel.  Thanks for pushing on this.

Thanks for the review!  I've just pushed v3 of what remains of this
series, which is basically the same as the remaining patches here, with
a couple minor cleanups.

you can find it starting at
id:20171208062404.17269-1-dkg@fifthhorseman.net

        --dkg
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Previous message (by thread): Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys

Thread:

Daniel Kahn Gillmor—session keys, version 2 [inbox, unread]
- Daniel Kahn Gillmor—[PATCH v2 01/21] mime-node: handle decrypt_result more safely [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 02/21] crypto: add _notmuch_crypto_decrypt wrapper function [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 03/21] configure: session key handling in gmime maps to built_with("session_key") [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, unread]
    - David Bremner—Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, unread]
- Daniel Kahn Gillmor—[PATCH v2 05/21] test/corpora: add an encrypted message for index decryption tests [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
    - Daniel Kahn Gillmor—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
    - Jameson Graef Rollins—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, signed, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
- Daniel Kahn Gillmor—[PATCH v2 07/21] indexing: Change from try_decrypt to decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 08/21] indexopts: change _try_decrypt to _decrypt_policy [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 09/21] lib: convert notmuch decryption policy to an enum [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 10/21] crypto: new decryption policy "auto" [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 11/21] cli/reply: use decryption policy "auto" by default. [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 12/21] cli/show: use decryption policy "auto" by default. [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 13/21] cli/show, reply: document use of stashed session keys in notmuch-properties [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 14/21] cli/new, insert, reindex: update documentation for --decrypt=auto [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 15/21] crypto: record whether an actual decryption attempt happened [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 16/21] cli/new, insert, reindex: change index.decrypt to "auto" by default [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 17/21] cli/reindex: destroy stashed session keys when --decrypt=false [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 18/21] crypto: actually stash session keys when decrypt=true [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 19/21] crypto: add --decrypt=nostash to avoid stashing session keys [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 20/21] docs: clean up documentation about decryption policies [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 21/21] python: add decrypt_policy argument to Database.index_file() [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—Re: [PATCH v2 21/21] python: add decrypt_policy argument to Database.index_file() [inbox, unread]