Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available

Subject: Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available

Date: Mon, 04 Dec 2017 21:47:03 -0400

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> On Thu 2017-11-30 03:59:29 -0500, Daniel Kahn Gillmor wrote:
>> +    hexidecimal representation of the algorithm-specific key.  For
>
> ugh, this should be hexadecimal, not hexidecimal.
>
> This is fixed in my gitlab session-keys branch [0], but doesn't seem
> worth re-posting the entire series for. :)
>

I've amended it by hand, but for future reference the usual convention
is to post an amended patch as a reply, and to mark the original as
obsolete in nmbug

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys

Thread:

• Daniel Kahn Gillmor—session keys, version 2 [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 01/21] mime-node: handle decrypt_result more safely [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v2 02/21] crypto: add _notmuch_crypto_decrypt wrapper function [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v2 03/21] configure: session key handling in gmime maps to built_with("session_key") [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, unread]
      • David Bremner—Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 05/21] test/corpora: add an encrypted message for index decryption tests [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
      • Jameson Graef Rollins—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, signed, unread]
        • Daniel Kahn Gillmor—Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 07/21] indexing: Change from try_decrypt to decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 08/21] indexopts: change _try_decrypt to _decrypt_policy [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 09/21] lib: convert notmuch decryption policy to an enum [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 10/21] crypto: new decryption policy "auto" [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 11/21] cli/reply: use decryption policy "auto" by default. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 12/21] cli/show: use decryption policy "auto" by default. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 13/21] cli/show, reply: document use of stashed session keys in notmuch-properties [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 14/21] cli/new, insert, reindex: update documentation for --decrypt=auto [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 15/21] crypto: record whether an actual decryption attempt happened [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 16/21] cli/new, insert, reindex: change index.decrypt to "auto" by default [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 17/21] cli/reindex: destroy stashed session keys when --decrypt=false [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 18/21] crypto: actually stash session keys when decrypt=true [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 19/21] crypto: add --decrypt=nostash to avoid stashing session keys [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 20/21] docs: clean up documentation about decryption policies [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v2 21/21] python: add decrypt_policy argument to Database.index_file() [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—Re: [PATCH v2 21/21] python: add decrypt_policy argument to Database.index_file() [inbox, unread]