Re: [PATCH] go: Update to the current notmuch_database_find_message API

Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message API

Date: Mon, 30 Apr 2012 08:53:47 -0300

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner

Austin Clements <amdragon@MIT.EDU> writes:

> The signature of notmuch_database_find_message was changed in 02a30767
> to report errors and the Go bindings were never updated.  This brings
> the Go bindings in sync with that change and at least makes them
> compile with Go r60.3, the last release before Go 1.

I don't have any easy way to test this, since the current versions in 
Debian are all based on Go 1.  On the other hand I guess it doesn't make
things worse.  Anybody have any objections to this patch?

In the long run we have to decide what to do about these bindings. Seb
(or anyone else) are you interested in porting them to Go 1 and
maintaining them?  Otherwise it may be time to deprecate them.

d

• Previous message (by thread): Re: [patch v2] update the go stuff to go 1

Thread:

• Austin Clements—[PATCH] go: Update to the current notmuch_database_find_message API [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—Re: [PATCH] go: Update to the current notmuch_database_find_message API [inbox, unread]
    • Justus Winter—Re: [PATCH] go: Update to the current notmuch_database_find_message API [inbox, unread]
      • Justus Winter—[PATCH 1/5] go: reorganize the go bindings [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Justus Winter—[PATCH 2/5] go: set LDFLAGS, fix include directive [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Justus Winter—[PATCH 3/5] go: update the addrlookup utility to go 1 [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Justus Winter—[PATCH 4/5] go: update the build system [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Justus Winter—[PATCH 5/5] go: format the souce code using gofmt [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Austin Clements—Re: [PATCH 1/5] go: reorganize the go bindings [inbox, notmuch::review, unread]
          • Austin Clements—Re: [PATCH 1/5] go: reorganize the go bindings [inbox, unread]
            • Justus Winter—Re: [PATCH 1/5] go: reorganize the go bindings [inbox, unread]
              • Justus Winter—[patch v2] update the go stuff to go 1 [inbox, unread]
                • Justus Winter—[PATCH 1/5] go: reorganize the go bindings [inbox, notmuch::patch, notmuch::pushed, unread]
                • Justus Winter—[PATCH 2/5] go: set LDFLAGS to -lnotmuch in the packages source file [inbox, notmuch::patch, notmuch::pushed, unread]
                • Justus Winter—[PATCH 3/5] go: update the addrlookup utility to go 1 [inbox, notmuch::patch, notmuch::pushed, unread]
                • Justus Winter—[PATCH 4/5] go: update the build system [inbox, notmuch::patch, notmuch::pushed, unread]
                • Justus Winter—[PATCH 5/5] go: format the souce code using gofmt [inbox, notmuch::patch, notmuch::pushed, unread]
                • Austin Clements—Re: [patch v2] update the go stuff to go 1 [inbox, notmuch::review, unread]
                • David Bremner—Re: [patch v2] update the go stuff to go 1 [inbox, unread]
      • —Re: [PATCH] go: Update to the current notmuch_database_find_message API [inbox, signed, unread]
  • David Bremner—Re: [PATCH] go: Update to the current notmuch_database_find_message API [inbox, unread]