Re: [PATCH v2 1/5] util: Factor out boolean term quoting routine

Subject: Re: [PATCH v2 1/5] util: Factor out boolean term quoting routine

Date: Wed, 26 Dec 2012 10:24:51 -0400

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner


Austin Clements <amdragon@MIT.EDU> writes:

> +/* Construct a boolean term query with the specified prefix (e.g.,
> + * "id") and search term, quoting term as necessary.
> + *
> + * Output is into buf; it may be talloc_realloced.
> + * Return: 0 on success, non-zero on memory allocation failure.
> + */
> +int make_boolean_term (void *talloc_ctx, const char *prefix, const char *term,
> +		       char **buf, size_t *len);
> +

I think the quoting should be described a bit more precisely here,
especially since you are going to refer to it in the comment above
parse_boolean_term.

d

Thread: