Austin Clements <amdragon@MIT.EDU> writes:

> This obsoletes
>
>   id:1356415076-5692-1-git-send-email-amdragon@mit.edu
>
> In addition to incorporating all of David's suggestions, this reworks
> the boolean term parsing so it only handles the subset of quoting
> syntax used by make_boolean_term (which also happens to be all that we
> described in the man page for the format).  The diff from v1 is below.

Implementation wise this series now looks OK to me; I think the dequote
routine could be slightly clearer, but it's a bit subjective at this
point.

IMHO the real question is if we like (or can live with) the resulting UI
for batch tagging.  Mark ( id:87ehid5h64.fsf@qmul.ac.uk ) brings up the
question of whether tags with newlines should be somehow supported in a
batch-tagging context. The other UI issue I'm aware of is the fact that
tags with spaces needed to be quoted in two different ways for tag
operations and for queries.  A relatively smooth upgrade path would be
to support Xapian quoting for tag operations in the future.

d