Re: [PATCH v2 03/17] test: new test framework to compare json parts

Subject: Re: [PATCH v2 03/17] test: new test framework to compare json parts

Date: Mon, 27 May 2019 17:31:53 +0000

To: David Bremner, Daniel Kahn Gillmor, Notmuch Mail

Cc:

On Mon, May 27 2019, David Bremner <david@tethera.net> wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>> +
>> +Value test: test that object in json data found at address is equal to specified value:
>> +
>> +  label:address|value
>> +
>
> should this maybe be label:address=value ? At least looking that the
> regex and the examples.

This description is wrong, the comparison actually uses '=' in the code
(and in the example).  I'll fix the usage.

jamie.
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Previous message (by thread): Re: stitching threads (v3 14/17)

Thread:

Daniel Kahn Gillmor—Protected Headers (2nd major revision, more testing!) [inbox, unread]
- Daniel Kahn Gillmor—[PATCH v2 01/17] cli/show: emit headers after emitting body [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 02/17] util/crypto: add information about the payload part [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 03/17] test: new test framework to compare json parts [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 03/17] test: new test framework to compare json parts [inbox, unread]
    - Rollins, Jameson—Re: [PATCH v2 03/17] test: new test framework to compare json parts [inbox, unread]
    - Daniel Kahn Gillmor—[PATCH v3 03/17] test: new test framework to compare json parts [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v3 03/17] test: new test framework to compare json parts [inbox, unread]
        Rollins, Jameson—Re: [PATCH v3 03/17] test: new test framework to compare json parts [inbox, unread]
  - Rollins, Jameson—[PATCH v3] test: new test framework to compare json parts [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 04/17] cli/show: add tests for viewing protected headers [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 05/17] cli/show: emit payload subject instead of outside subject [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 06/17] cli/show: add information about which headers were protected [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 06/17] cli/show: add information about which headers were protected [inbox, unread]
    - Rollins, Jameson—Re: [PATCH v2 06/17] cli/show: add information about which headers were protected [inbox, unread]
      - David Bremner—Re: [PATCH v2 06/17] cli/show: add information about which headers were protected [inbox, unread]
    - Daniel Kahn Gillmor—[PATCH v3 06/17] cli/show: add information about which headers were protected [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v3 06/17] cli/show: add information about which headers were protected [inbox, signed, unread]
    - Daniel Kahn Gillmor—Re: [PATCH v2 06/17] cli/show: add information about which headers were protected [inbox, notmuch::obsolete, notmuch::patch, signed, unread]
    - Daniel Kahn Gillmor—[PATCH v4 06/17] cli/show: add information about which headers were protected [inbox, notmuch::patch, notmuch::pushed, unread]
      - David Bremner—Re: [PATCH v4 06/17] cli/show: add information about which headers were protected [inbox, unread]
        Daniel Kahn Gillmor—Re: [PATCH v4 06/17] cli/show: add information about which headers were protected [inbox, signed, unread]
- Daniel Kahn Gillmor—[PATCH v2 07/17] test: add test for missing external subject [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 08/17] test: show cryptographic envelope information for signed mails [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 09/17] cli/reply: ensure encrypted Subject: line does not leak in the clear [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 10/17] indexing: record protected subject when indexing cleartext [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 10/17] indexing: record protected subject when indexing cleartext [inbox, unread]
    - Daniel Kahn Gillmor—[PATCH v3 10/17] indexing: record protected subject when indexing cleartext [inbox, notmuch::obsolete, notmuch::patch, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v3 10/17] indexing: record protected subject when indexing cleartext [inbox, signed, unread]
    - Daniel Kahn Gillmor—_notmuch_database_log vs _notmuch_database_log_append [was: Re: [PATCH v2 10/17] indexing: record protected subject when indexing cleartext] [inbox, notmuch::bug, notmuch::wishlist, signed, unread]
    - Daniel Kahn Gillmor—[PATCH v4 10/17] indexing: record protected subject when indexing cleartext [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 11/17] test: protected headers should work when both encrypted and signed. [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 12/17] test: after reindexing, only legitimate protected subjects are searchable [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 13/17] test: try indexing nested messages and protected headers [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected [inbox, notmuch::patch, notmuch::pushed, unread]
  - Rollins, Jameson—Re: [PATCH v2 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected [inbox, unread]
    - Daniel Kahn Gillmor—stitching threads (v3 14/17) [inbox, notmuch::bug, notmuch::moreinfo, signed, unread]
      - David Bremner—Re: stitching threads (v3 14/17) [inbox, unread]
- Daniel Kahn Gillmor—[PATCH v2 15/17] test: emacs/show: ensure that protected headers appear as expected [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 16/17] test: reply (in cli and emacs) should protect indexed sensitive headers [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—[PATCH v2 17/17] cli/reply: pull proposed subject line from the message, not the index [inbox, notmuch::patch, notmuch::pushed, unread]
- Rollins, Jameson—Re: Protected Headers (2nd major revision, more testing!) [inbox, unread]
- Daniel Kahn Gillmor—Re: Protected Headers (2nd major revision, more testing!) [inbox, signed, unread]
- David Bremner—Re: Protected Headers (2nd major revision, more testing!) [inbox, unread]
  - Daniel Kahn Gillmor—Re: Protected Headers (2nd major revision, more testing!) [inbox, signed, unread]
Daniel Kahn Gillmor—[PATCH v3 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected [inbox, notmuch::patch, notmuch::pushed, unread]
- Daniel Kahn Gillmor—Re: [PATCH v3 14/17] test: ensure that protected headers appear in notmuch-emacs search as expected [inbox, signed, unread]