Re: [PATCH v4 06/17] cli/show: add information about which headers were protected

Subject:Re: [PATCH v4 06/17] cli/show: add information about which headers were protected

Date:Tue, 28 May 2019 08:10:35 -0300

To:Daniel Kahn Gillmor ,Notmuch Mail

Cc:

From:David Bremner


Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>      decrypted?: {
>                    status: msgdecstatus,
> +                  # map encrypted headers that differed from the outside headers.
> +                  # the value of each item in the map is what that field showed externally
> +                  # (maybe null if it was not present in the external headers).
> +                  header-mask:  { header_name: string|null,*}
>                  }

Apologies for not catching this before (and for fussing so much about
the schemata file), but this notation for repeated key-value pairs
doesn't seem ideal to me. I would say either

        header-mask: { (header_name: string|null)* }
        header-mask: { header_name*: string|null }

Either would need a brief explanation above, as this the first map
defined with an arbitrary number of members.


_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: