Re: [notmuch] [PATCH] Switch from random to sequential thread identifiers.

Subject: Re: [notmuch] [PATCH] Switch from random to sequential thread identifiers.

Date: Tue, 09 Feb 2010 11:22:54 -0800

To: Sebastian Spaeth, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Tue, 09 Feb 2010 11:35:39 +0100, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> On Mon, 08 Feb 2010 13:36:14 -0800, Carl Worth <cworth@cworth.org> wrote:
> > -NOTMUCH_THREAD_ID_SQUELCH='s/thread:................................/thread:XXX/'
> > +NOTMUCH_THREAD_ID_SQUELCH='s/thread:..................../thread:XXX/'
> 
> Caught you not running your test suite before submitting v2 of a patch!
> :-)

Drat, I'm exposed.

And silly of me since this patch is what enables the test suite to
complete in less than 2 seconds now. So I really don't have any excuse
to not run it anymore.

Anyway, I do appreciate all the review. I haven't seen any complaints,
so I'll go ahead and push these changes out, (a version 3 including a
fix for the above...and which I *have* tested with the test suite).

-Carl

part-000.sig (application/pgp-signature)

Thread: