Re: [PATCH v2 2/2] Replace `delete-line` with its definition

Subject: Re: [PATCH v2 2/2] Replace `delete-line` with its definition

Date: Tue, 18 Jun 2024 07:58:09 +0200

To: David Bremner, michaeljgruber+grubix+git@gmail.com, notmuch@notmuchmail.org

Cc:

From: Marc Fargas

Hi,

El lun. 17 de jun. 2024, David escribió:
>
>> From: Michael J Gruber <git@grubix.eu>
>>
>> 37c022ae ("Use `without-restriction` in `with-temporary-notmuch-message-buffer`", 2024-03-14)
>> introduced `delete-line` in a test, but this is Emacs 29 and above only.
>> Replace it with its (almost) definition.
>
> The changes look reasonable to me. But so did the last ones ;P. Any
> feedback Marc?

Ok for me! And sorry for not considering backwards compatibility on my
patch :(

marc
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): Re: [PATCH v2 2/2] Replace `delete-line` with its definition

Thread:

• Marc Fargas—notmuch.el, needs without-restriction to properly save draft [inbox, unread]
  • Carl Worth—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
    • Marc Fargas—[PATCH] Use `without-restriction` in `with-temporary-notmuch-message-buffer` [inbox, unread]
      • Marc Fargas—Re: [PATCH] Use `without-restriction` in `with-temporary-notmuch-message-buffer` [inbox, unread]
        • David Bremner—Re: [PATCH] Use `without-restriction` in `with-temporary-notmuch-message-buffer` [inbox, unread]
    • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [attachment, inbox, unread]
      • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [attachment, inbox, notmuch::patch, notmuch::pushed, unread]
        • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
        • David Bremner—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
          • Michael J Gruber—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
            • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
              • David Bremner—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
                • David Bremner—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
              • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
                • michaeljgruber+grubix+git@gmail.com—[PATCH] Replace `without-restriction` with `save-restriction` [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • michaeljgruber+grubix+git@gmail.com—[PATCH v2 1/2] Replace `without-restriction` with `save-restriction` [inbox, notmuch::patch, notmuch::pushed, unread]
                  • michaeljgruber+grubix+git@gmail.com—[PATCH v2 2/2] Replace `delete-line` with its definition [inbox, notmuch::patch, notmuch::pushed, unread]
                    • David Bremner—Re: [PATCH v2 2/2] Replace `delete-line` with its definition [inbox, unread]
                      • Marc Fargas—Re: [PATCH v2 2/2] Replace `delete-line` with its definition [inbox, unread]
                        • Michael J Gruber—Re: [PATCH v2 2/2] Replace `delete-line` with its definition [inbox, unread]
                    • David Bremner—Re: [PATCH v2 2/2] Replace `delete-line` with its definition [inbox, unread]
                • David Bremner—Re: notmuch.el, needs without-restriction to properly save draft [inbox, unread]
    • Marc Fargas—Re: notmuch.el, needs without-restriction to properly save draft [attachment, inbox, unread]