Re: [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

Subject: Re: [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

Date: Tue, 01 Nov 2011 14:17:51 -0700

To: Pieter Praet, notmuch@notmuchmail.org

Cc:

On Tue,  1 Nov 2011 20:49:11 +0100, Pieter Praet <pieter@praet.org> wrote:
> -test_expect_success 'emacs delivery of signed message' \
> +test_expect_success GPG 'emacs delivery of signed message' \

Hi, Pieter and Thomas.  Thanks for all the work on this, but I have one
issue.  Is there a way we can do this without adding a new argument to
every test function?  For some reason I really don't like that solution.
It seems too invasive.  Can't we have something that works more like
test_subtest_known_broken, that modifies the test environment, rather
than add an argument to every call of every testing function?

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs"

Thread:

Pieter Praet—set test prereqs (Emacs, GDB, GPG) v4 [inbox, unread]
- Pieter Praet—[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
  - Jameson Graef Rollins—Re: [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests [inbox, signed, unread]
    - Pieter Praet—Re: [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests [inbox, unread]
- Pieter Praet—[PATCH 2/4] test: add 'Emacs' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
- Pieter Praet—[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
- Pieter Praet—[PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
- Ali Polatel—Re: set test prereqs (Emacs, GDB, GPG) v4 [inbox, signed, unread]
  - Pieter Praet—Re: set test prereqs (Emacs, GDB, GPG) v4 [inbox, unread]
- Thomas Jost—[PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, unread]
  - Thomas Jost—[PATCH 1/6] test: define a helper function for defining prereqs on executables [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Thomas Jost—[PATCH 2/6] test: check if emacs and dtach are available in test_emacs() [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Thomas Jost—[PATCH 3/6] test: add 'GnuPG' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Thomas Jost—[PATCH 4/6] test: add 'Emacs' prereq to dependent 'crypto' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Thomas Jost—[PATCH 5/6] test: add 'Emacs' prereq to dependent 'emacs' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Thomas Jost—[PATCH 6/6] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jameson Graef Rollins—Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, signed, unread]
    - Thomas Jost—Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, signed, unread]
  - Pieter Praet—Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, unread]
    - Thomas Jost—Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, signed, unread]
      - Pieter Praet—Re: [PATCH 0/6] Rebase of Pieter's "set test prereqs" [inbox, unread]