Re: [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned CHAR

Subject: Re: [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned CHAR

Date: Sat, 16 Feb 2013 07:37:37 -0400

To: Robert Mast, notmuch@notmuchmail.org

Cc:

From: David Bremner


Robert Mast <beheerder@tekenbeetziekten.nl> writes:

> Using char instead of int allows for simpler definitions of the
> DOCIDSET macros so the code is easier to understand and consistent with
> respect to memory-usage. Estimated reduction of memory-usage for
> bitmap about 8 times.

Pushed to master.

I did a bit of testing, and this yields about a 7% improvement in the
total memory allocated on the medium corpus (running
performance-tests/M00-new) and about a 3% speedup running the large
corpus.  These are definitely improvements worth having, but I think I
won't push it to the bug fix release, but rather wait for the next
regular release.

d



Thread: