Re: [PATCH] lib/database.cc: fix misleading indentation

Subject: Re: [PATCH] lib/database.cc: fix misleading indentation

Date: Thu, 20 Oct 2016 20:45:00 -0300

To: Franz Fellner, Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner


Franz Fellner <alpine.art.de@gmail.com> writes:

> From a quick visual scan at least half the indented lines start with 4 spaces
> instead of TABS. As I understand the quoted paragraph that should be wrong.
>

Can you be specific what what lines in what file? I have the feeling
you're misinterpreting something, or looking at a different file.

>> that _should_ be enforced by devel/uncrustify.cfg
>
> When was uncrustify used the last time? I simply ran it on lib/database.cc and
> it produced a diff with 661 lines - the leading spaces were NOT fixed ;)
>

No idea if it was ever done globally. But I'm also not sure which
leading spaces you are talking about.

d

Thread: