Re: [PATCH] lib/database.cc: fix misleading indentation

Subject: Re: [PATCH] lib/database.cc: fix misleading indentation

Date: Fri, 21 Oct 2016 08:01:40 +0100

To: Franz Fellner, David Bremner, Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Mark Walters


Hi

> * the first line in the first for loop is indented by only one TAB (IMHO should be
>   two, because it is one leven down): this is a pattern you can find throughout the
>   codebase.

I think  this is the key confusion -- the notmuch convention is that 
1 tab = 8 spaces

The only other rule is that you should prefer tabs to spaces so you
should never have more than 7 spaces -- for example an indentation of 12
would be 1 tab + 4 spaces.

Best wishes

Mark



> * the next two lines are indented by four spaces
> * the first line of the second for-loop is indented by one TAB.
> * and so on...
>
> Am I misinterpreting something here? Is this intended to be done that way?
> I also get confused by the different lengths of TAB/space-indenting. But probably
> that's because I never used it...
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Thread: