Re: [PATCH] emacs: Make the queries used in the all-tags section

Subject: Re: [PATCH] emacs: Make the queries used in the all-tags section

Date: Thu, 26 May 2011 15:04:07 -0700

To: Daniel Schoepe, Austin Clements

Cc: notmuch@notmuchmail.org

From: Carl Worth

On Wed, 25 May 2011 23:21:54 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> I incorporated most of you recommendations in the attached patch.

Looks good, thanks!

I've pushed this out now.

I only have two suggestions:

1. Could you please add some basic testing for this?

   The existing notmuch-hello tests should make a good starting point.

2. The hello screen is now lying a bit by saying "all tags".

   Perhaps if the user has the notmuch-hello-hide-tags variable set to
   non-nil the text might change somewhat? I'm not sure to what exactly.

-Carl

-- 
carl.d.worth@intel.com

• Previous message (by thread): Re: [PATCH] emacs: Make the queries used in the all-tags section

Thread:

• Daniel Schoepe—[PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
  • Carl Worth—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
    • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
      • Carl Worth—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
  • Austin Clements—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, unread]
    • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
      • Austin Clements—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, unread]
        • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
          • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
            • Austin Clements—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, unread]
              • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
                • Austin Clements—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, unread]
                  • Daniel Schoepe—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
                    • Carl Worth—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
                • Carl Worth—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]
                  • Daniel Kahn Gillmor—Re: [PATCH] emacs: Make the queries used in the all-tags section [inbox, signed, unread]