Re: [PATCH] emacs: Make the queries used in the all-tags section

Subject: Re: [PATCH] emacs: Make the queries used in the all-tags section

Date: Tue, 24 May 2011 13:39:44 -0700

To: Daniel Schoepe, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Fri, 20 May 2011 01:18:35 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> From the commit message:
> 
>     emacs: Make queries used in the all-tags section configurable
>     
>     This patch adds a customization variable that controls what queries
>     are used to construct the all-tags section in notmuch-hello. It allows
>     the user to specify a function to construct the query given a tag. It
>     also allows hiding tags by returning nil.

This seems like a useful feature, but perhaps it's a little too general?

I'm imagining a user wanting to use this functionality but not knowing
anything about writing an emacs-lisp function. For such a user, this
variable won't provide much of a feature.

I think that might be an argument for dropping this variable from the
notmuch customization group. That customization page is starting to get
crowded, and if there are things there that can't be easily manipulated
with the available controls, I think they're mostly just clutter.

Perhaps this could be addressed by allowing this variable to be an alist
instead of (or in addition to) a function. What do you think?

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: