Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

Date: Sat, 24 Nov 2012 21:18:01 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


>
> Maybe something like the following formatted and consistency-tuned version:
>
> typedef enum { 
>    TAG_FLAG_NONE = 0,
>
>    /* Operations are synced to maildir, if possible.
>     */
>    TAG_FLAG_MAILDIR_SYNC = (1 << 0),
>
>    /* Remove all tags from message before applying list.
>     */
>    TAG_FLAG_REMOVE_ALL = (1 << 1),
>
>    /* Don't try to avoid database operations. Useful when we
>     * know that message passed needs these operations.
>     */
>    TAG_FLAG_PRE_OPTIMIZED = (1 << 2),
>
>    /* Accept strange tags that might be user error;
>     * intended for use by notmuch-restore.
>     */
>    TAG_FLAG_BE_GENEROUS = (1 << 3)
>
> } tag_op_flag_t;
>

Applied.  We may have to fight uncrustify on this, but we both know who
likes to play with uncrustify config ;).

d


Thread: