Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers

Subject: Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers

Date: Wed, 21 Jun 2017 12:11:27 -0400

To: Piotr Trojanek, notmuch@notmuchmail.org

Cc:

From: Daniel Kahn Gillmor

this series up to patch 4 LGTM, and seem uncontroversial.  patch 5 adds
FIXMEs that should probably actually be fixed, though, rather than just
flagged.

Thanks to Piotr for identifying these issues and suggesting the
cleanup.

         --dkg

• Previous message (by thread): Re: [PATCH 3/5] remove ineffective assignments

Thread:

• Piotr Trojanek—[PATCH 1/5] minor whitespace cleanups [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • Piotr Trojanek—[PATCH 2/5] add leaks due to missing invocations of va_end [inbox, notmuch::patch, notmuch::pushed, unread]
  • Piotr Trojanek—[PATCH 3/5] remove ineffective assignments [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—Re: [PATCH 3/5] remove ineffective assignments [inbox, unread]
  • Piotr Trojanek—[PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, unread]
      • Piotr Trojanek—Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, unread]
        • David Bremner—Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, unread]
        • David Bremner—Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, unread]
    • David Bremner—Re: [PATCH 4/5] fix wrong printf formatting of signed/unsigned integers [inbox, unread]
  • Piotr Trojanek—[PATCH 5/5] flag potential problems with FIXME [inbox, notmuch::moreinfo, notmuch::patch, unread]
  • David Bremner—Re: [PATCH 1/5] minor whitespace cleanups [inbox, unread]