Re: [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output

Subject: Re: [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output

Date: Wed, 01 Jun 2011 16:41:21 -0700

To: Jameson Graef Rollins, Notmuch Mail

Cc:

From: Carl Worth

On Sat, 28 May 2011 14:51:42 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> The test in json was inferior to the one in search-output, since it
> wasn't properly testing for the presence of a trailing newline.

Hi Jamie,

I've pushed the series up to this point now, (along with the vim
improvements that weren't in your original mailing of the series).

I really appreciate the missing-newline bug-fix along with all the
improved testing for that. Thanks! I re-ordered that portion of the
patch series a tiny bit to put the bug fix immediately after the commit
that makes the tests start failing. I also reworded a few commit
messages slightly.

But I didn't make any code changes so it's trivial enough for me to keep
using "git rebase" to keep your series on top of my modified master.

I'll keep posting as I'm pushing.

-Carl

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: tag sharing

Thread:

Jameson Graef Rollins—release-candidate/0.6 redux [inbox, unread]
- Jameson Graef Rollins—[PATCH 01/25] fix check for libdir in ldconfig paths [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jameson Graef Rollins—[PATCH 02/25] add note about updating the debian symbols file to the RELEASE file [inbox, notmuch::patch, notmuch::pushed, unread]
    - Jameson Graef Rollins—[PATCH 03/25] test: modify search-output test to use the new test_expect_equal_file function [inbox, unread]
      - Jameson Graef Rollins—[PATCH 04/25] test: move "Search for non-existent message prints nothing" to search-output, and add similar test for format=json [inbox, unread]
        Jameson Graef Rollins—[PATCH 05/25] fix trailing newlines in notmuch search [inbox, unread]
        Jameson Graef Rollins—[PATCH 06/25] test: move utf-8 subject search test from json to search test script [inbox, unread]
        Jameson Graef Rollins—[PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output [inbox, unread]
        Jameson Graef Rollins—[PATCH 08/25] create and set temporary home directory [inbox, unread]
        Jameson Graef Rollins—[PATCH 09/25] emacs: Define several faces for the crypto-status button [inbox, unread]
        Jameson Graef Rollins—[PATCH 10/25] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search [inbox, unread]
        Jameson Graef Rollins—[PATCH 11/25] test: add test for sanitized notmuch-search output [inbox, unread]
        Jameson Graef Rollins—[PATCH 12/25] test: cleanup search-output test names (no functional change) [inbox, unread]
        Jameson Graef Rollins—[PATCH 13/25] emacs: Use "message-cited-text" instead of "message-cited-text-face" [inbox, unread]
        Jameson Graef Rollins—[PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, unread]
        Jameson Graef Rollins—[PATCH 15/25] Use message-field-value instead of message-fetch-field in FCC header setup. [inbox, unread]
        Jameson Graef Rollins—[PATCH 16/25] lib/message-file: plug three memleaks. [inbox, unread]
        Jameson Graef Rollins—[PATCH 17/25] avoid segfault when calling sanitize_string() on NULL [inbox, unread]
        Jameson Graef Rollins—[PATCH 18/25] Fix search output sanitization test. [inbox, unread]
        Jameson Graef Rollins—[PATCH 19/25] emacs: fix notmuch-show-part-button to not include newline [inbox, unread]
        Jameson Graef Rollins—[PATCH 20/25] emacs: Don't always prompt for the "From" address when replying [inbox, unread]
        Jameson Graef Rollins—[PATCH 21/25] emacs: Cleaner interface when prompting for sender address [inbox, unread]
        Jameson Graef Rollins—[PATCH 22/25] test: fix test_expect_equal_file test to copy instead of mv test files [inbox, unread]
        Jameson Graef Rollins—[PATCH 23/25] test: update emacs test to use test_expect_equal_file [inbox, unread]
        Jameson Graef Rollins—[PATCH 24/25] test: modify multipart test to use test_expect_equal_file [inbox, unread]
        Jameson Graef Rollins—[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, unread]
        Carl Worth—Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, signed, unread]
        Carl Worth—Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text [inbox, signed, unread]
        Carl Worth—Re: [PATCH 17/25] avoid segfault when calling sanitize_string() on NULL [inbox, signed, unread]
        Carl Worth—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, signed, unread]
        Dmitry Kurochkin—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, unread]
        Carl Worth—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, signed, unread]
        Dmitry Kurochkin—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, unread]
        Carl Worth—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, signed, unread]
        Carl Worth—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, signed, unread]
        Dmitry Kurochkin—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, unread]
        Carl Worth—Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check. [inbox, signed, unread]
        Carl Worth—Re: [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output [inbox, signed, unread]
  - Carl Worth—Re: [PATCH 01/25] fix check for libdir in ldconfig paths [inbox, signed, unread]
    - Jameson Graef Rollins—Re: [PATCH 01/25] fix check for libdir in ldconfig paths [inbox, signed, unread]
- Jameson Graef Rollins—Re: release-candidate/0.6 redux [inbox, signed, unread]
  - Austin Clements—Re: release-candidate/0.6 redux [inbox, unread]
  - Jameson Graef Rollins—Re: release-candidate/0.6 redux [inbox, signed, unread]
    - Carl Worth—Re: release-candidate/0.6 redux [inbox, signed, unread]
      - Jameson Graef Rollins—Re: release-candidate/0.6 redux [inbox, signed, unread]
        Carl Worth—Re: release-candidate/0.6 redux [inbox, signed, unread]
        Jameson Graef Rollins—tag sharing [was: Re: release-candidate/0.6 redux] [inbox, signed, unread]
        Jesse Rosenthal—Re: tag sharing [was: Re: release-candidate/0.6 redux] [inbox, unread]
        Jameson Graef Rollins—Re: tag sharing [was: Re: release-candidate/0.6 redux] [inbox, signed, unread]
        Jesse Rosenthal—Re: tag sharing [was: Re: release-candidate/0.6 redux] [inbox, unread]
        David Bremner—Re: tag sharing [inbox, unread]
        Jesse Rosenthal—Re: tag sharing [inbox, unread]
        David Bremner—Re: tag sharing [inbox, signed, unread]
        Jesse Rosenthal—Re: tag sharing [inbox, unread]
        David Bremner—Re: tag sharing [inbox, unread]
        Jesse Rosenthal—Re: tag sharing [inbox, unread]
        David Bremner—Re: tag sharing [inbox, unread]
        Jesse Rosenthal—Re: tag sharing [inbox, unread]
        Jesse Rosenthal—Re: tag sharing [inbox, unread]