On Sat, 28 May 2011 14:51:49 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
Hi Jamie,
I've pushed the next few patches up to this point, (with only one
functional change---I fixed a new test case to correctly use
notmuch_search_sanitize to avoid spurious failures unmatching thread ID
values).
This patch, however, isn't ready. The big problem is in this commit
message:
> From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
>
> In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code
> did not correctly identify an old configuration and, as a
> consequence, broke new configurations.
There are several things there that are too vague, ("previous code",
"old configuration", "new configurations"). What kind of configuration
is broken? How does the change here help?
It would be easier to understand the code if there were a corresponding
test case for it. I'd even be willing to help write a test case, but
there are not enough specifics in that commit message to even tell me
what to test.
> ((and (listp notmuch-fcc-dirs)
> - (= 1 (length (car notmuch-fcc-dirs))))
> + (stringp (car notmuch-fcc-dirs)))
So the "old configuration" was a single string? And this has been
inadvertently broken since 0.5?
> ;; Old style - no longer works.
> (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
Yikes. That vague phrasing ("old style") is already in the code in error
messages as well.
Dmitry, can you help me know what's going on here? (Preferably by
sending a newer commit with a more thorough commit message.)
Thanks,
-Carl