Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files

Subject: Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files

Date: Mon, 16 Jan 2012 22:17:58 -0800

To: Austin Clements, Tomi Ollila

Cc: notmuch@notmuchmail.org

From: Jameson Graef Rollins

On Mon, 16 Jan 2012 23:32:00 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Cleanup is the type of pain that should only be suffered once, so I'd
> be much happier with this if there was an accompanying git hook that
> prevented more mis-formatted code from slipping in.

Agreed.  However, if we're really going to go down this pedantic route,
we need to make sure it is very easy for new contributors to know,
apply, and develop with these new rules.  Otherwise we're asking for a
lot more review churn on the list, and more frustration on the part of
potential contributors.

jamie.

• Previous message (by thread): Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files

Thread:

• Tomi Ollila—[PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Xavier Maillard—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, unread]
    • David Edmondson—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, signed, unread]
      • Tomi Ollila—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, unread]
        • David Edmondson—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, signed, unread]
          • Tomi Ollila—[PATCH 1/3] emacs/*.el: changed one-char comment prefix ';' to two: ';;' [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Tomi Ollila—[PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Austin Clements—Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files [inbox, notmuch::review, unread]
                • Jameson Graef Rollins—Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files [inbox, signed, unread]
                • Tomi Ollila—Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files [inbox, unread]
                  • Austin Clements—Re: [PATCH 2/3] emacs: whitespace-cleanup and indent-region for emacs/*.el files [inbox, unread]
            • Tomi Ollila—[PATCH 3/3] RFC: batch-tools.el [inbox, notmuch::obsolete, notmuch::patch, unread]
            • David Edmondson—Re: [PATCH 1/3] emacs/*.el: changed one-char comment prefix '; ' to two: '; ; ' [inbox, signed, unread]
            • Austin Clements—Re: [PATCH 1/3] emacs/*.el: changed one-char comment prefix ';' to two: ';;' [inbox, notmuch::review, unread]
        • Xavier Maillard—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, unread]
          • David Bremner—Re: [PATCH] emacs: whitespace-cleanup for emacs/*.el files [inbox, unread]