[PATCH] emacs: derive correct timestamp in FCC unique name

Subject: [PATCH] emacs: derive correct timestamp in FCC unique name

Date: Wed, 13 Jun 2012 16:01:27 -0400

To: notmuch@notmuchmail.org

Cc:

From: Jesse Rosenthal

Previously, the timestamp at the beginning of the FCC maildir unique
maildir name was derived incorrectly, thanks to an integer
overflow. This changes the derivation of timestamp to float
arithmetic, and so gets the number correct. (It is still formatted
with "%d" so it will show up as an integer.)

This change is mostly a question of consistency, since the unique name
is arbitrary anyway. But since most people use timestamps, and that was
the original intention here as well, we might as well.

Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>
---
 emacs/notmuch-maildir-fcc.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index dcfbc4b..6fd8ff9 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -141,7 +141,7 @@ will NOT be removed or replaced."
 
 (defun notmuch-maildir-fcc-make-uniq-maildir-id ()
    (let* ((ct (current-time))
-	  (timeid (+ (* (car ct) 65536) (cadr ct)))
+	  (timeid (+ (* (car ct) 65536.0) (cadr ct)))
 	  (microseconds (car (cdr (cdr ct))))
 	  (hostname (notmuch-maildir-fcc-host-fixer system-name)))
      (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))
-- 
1.7.9.5

Thread: