Re: [PATCH] test: make it possible to have multiple corpora

Subject: Re: [PATCH] test: make it possible to have multiple corpora

Date: Sun, 11 Sep 2016 14:29:32 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner


Jani Nikula <jani@nikula.org> writes:

> We largely use the corpus under test/corpus for
> testing. Unfortunately, many of our tests have grown to depend on
> having exactly this set of messages, making it hard to add new message
> files for testing specific cases.
>
> Move the basic corpus under tests/corpora/default, and make it
> possible to add new, independent corpora along its side. This means
> tons of renames with a few tweaks to add_email_corpus function in
> test-lib.sh to let tests specify which corpus to use.
>
> ---
>
> This is to address id:87pooc1t4s.fsf@zancas.localnet

It seems unobjectionable, but tbh I don't understand the problem it is
solving. Do you plan to ship static test corpuses for individual test
files, rather than using add_message?

d

Thread: